Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify catching exceptions in the Graphical User Interface #1295

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

bartfeenstra
Copy link
Owner

No description provided.

@bartfeenstra bartfeenstra added bug Something isn't working enhancement New feature or request BC break Breaks backwards compatibility with existing integrations labels Feb 21, 2024
@bartfeenstra bartfeenstra added this to the 0.3.0 milestone Feb 21, 2024
@bartfeenstra bartfeenstra marked this pull request as ready for review February 21, 2024 17:25
Copy link

Uploaded Betty for commit 5688434. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (9d188f7) 92.58% compared to head (5688434) 92.49%.
Report is 1 commits behind head on 0.3.x.

Files Patch % Lines
betty/gui/app.py 42.50% 23 Missing ⚠️
betty/gui/project.py 46.15% 21 Missing ⚠️
betty/extension/nginx/__init__.py 20.00% 4 Missing ⚠️
betty/gui/serve.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.x    #1295      +/-   ##
==========================================
- Coverage   92.58%   92.49%   -0.09%     
==========================================
  Files          81       81              
  Lines        9166     9156      -10     
==========================================
- Hits         8486     8469      -17     
- Misses        680      687       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartfeenstra bartfeenstra merged commit 72ea42a into 0.3.x Feb 21, 2024
9 of 11 checks passed
@bartfeenstra bartfeenstra deleted the simplify-gui-catch-exceptions branch February 21, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC break Breaks backwards compatibility with existing integrations bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant