Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch and populate place coordinates from Wikipedia #1136

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

bartfeenstra
Copy link
Owner

This fixes #1117

@bartfeenstra bartfeenstra added the enhancement New feature or request label Jan 7, 2024
@bartfeenstra bartfeenstra added this to the 0.3.0 milestone Jan 7, 2024
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (932b0ed) 92.46% compared to head (20eaea5) 91.63%.

Files Patch % Lines
betty/wikipedia.py 82.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.x    #1136      +/-   ##
==========================================
- Coverage   92.46%   91.63%   -0.83%     
==========================================
  Files          74       74              
  Lines        8481     8513      +32     
==========================================
- Hits         7842     7801      -41     
- Misses        639      712      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 7, 2024

Uploaded Betty for commit 20eaea5. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra merged commit 5a6e70b into 0.3.x Jan 7, 2024
9 of 11 checks passed
@bartfeenstra bartfeenstra deleted the wikipedia-fetch-place-coordinates branch January 7, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetch place coordinates from Wikipedia
1 participant