Upgrade to Ruff 0.5

.ruff.toml

@@ -22,6 +22,7 @@ ignore = [
     'D401',
     'F501',
     'PTH123',
+    'SIM103',
 ]
 
 [lint.per-file-ignores]

betty/tests/extension/cotton_candy/test_search.py

@@ -28,7 +28,7 @@ async def test_build_empty(self, new_temporary_app: App) -> None:
                 async for item in Index(project, Context(), DEFAULT_LOCALIZER).build()
             ]
 
-            assert [] == indexed
+            assert indexed == []
 
     async def test_build_person_without_names(self, new_temporary_app: App) -> None:
         person_id = "P1"
@@ -50,7 +50,7 @@ async def test_build_person_without_names(self, new_temporary_app: App) -> None:
                 async for item in Index(project, Context(), DEFAULT_LOCALIZER).build()
             ]
 
-            assert [] == indexed
+            assert indexed == []
 
     async def test_build_private_person(self, new_temporary_app: App) -> None:
         person_id = "P1"
@@ -80,7 +80,7 @@ async def test_build_private_person(self, new_temporary_app: App) -> None:
                 async for item in Index(project, Context(), DEFAULT_LOCALIZER).build()
             ]
 
-            assert [] == indexed
+            assert indexed == []
 
     @pytest.mark.parametrize(
         ("expected", "locale"),
@@ -270,7 +270,7 @@ async def test_build_private_place(self, new_temporary_app: App) -> None:
                 async for item in Index(project, Context(), DEFAULT_LOCALIZER).build()
             ]
 
-            assert [] == indexed
+            assert indexed == []
 
     async def test_build_file_without_description(self, new_temporary_app: App) -> None:
         file_id = "F1"
@@ -295,7 +295,7 @@ async def test_build_file_without_description(self, new_temporary_app: App) -> N
                 async for item in Index(project, Context(), DEFAULT_LOCALIZER).build()
             ]
 
-            assert [] == indexed
+            assert indexed == []
 
     @pytest.mark.parametrize(
         ("expected", "locale"),
@@ -354,4 +354,4 @@ async def test_build_private_file(self, new_temporary_app: App) -> None:
                 async for item in Index(project, Context(), DEFAULT_LOCALIZER).build()
             ]
 
-            assert [] == indexed
+            assert indexed == []

betty/tests/extension/gramps/test_gui.py

@@ -97,4 +97,4 @@ async def test_remove_family_tree(
         betty_qtbot.mouse_click(widget._family_trees._family_trees_remove_buttons[0])
 
         assert len(sut.configuration.family_trees) == 0
-        assert [] == widget._family_trees._family_trees_remove_buttons
+        assert widget._family_trees._family_trees_remove_buttons == []

betty/tests/model/test___init__.py

@@ -231,7 +231,7 @@ async def test_clear(self) -> None:
         entity3 = SingleTypeEntityCollectionTestEntity()
         sut.add(entity1, entity2, entity3)
         sut.clear()
-        assert [] == list(sut)
+        assert list(sut) == []
 
     async def test_list(self) -> None:
         sut = SingleTypeEntityCollection[Entity](Entity)
@@ -423,7 +423,7 @@ async def test_remove(self) -> None:
         sut.remove(entity_one)
         assert [entity_other] == list(sut)
         sut.remove(entity_other)
-        assert [] == list(sut)
+        assert list(sut) == []
 
     async def test_getitem_by_index(self) -> None:
         sut = MultipleTypesEntityCollection[Entity]()
@@ -451,7 +451,7 @@ async def test_getitem_by_entity_type(self) -> None:
         assert [entity_one] == list(sut[MultipleTypesEntityCollectionTestEntityOne])
         assert [entity_other] == list(sut[MultipleTypesEntityCollectionTestEntityOther])
         # Ensure that getting previously unseen entity types automatically creates and returns a new collection.
-        assert [] == list(sut[Entity])
+        assert list(sut[Entity]) == []
 
     async def test_getitem_by_entity_type_name(self) -> None:
         sut = MultipleTypesEntityCollection[Entity]()
@@ -1151,7 +1151,7 @@ async def test(self) -> None:
 
         del entity_many.one
         assert entity_many.one is None
-        assert [] == list(entity_one.many)  # type: ignore[unreachable]
+        assert list(entity_one.many) == []  # type: ignore[unreachable]
 
 
 @to_many(
@@ -1182,7 +1182,7 @@ async def test(self) -> None:
         assert [entity_many] == list(entity_one.many)
 
         entity_one.many.remove(entity_many)
-        assert [] == list(entity_one.many)
+        assert list(entity_one.many) == []
 
 
 @one_to_many(
@@ -1220,7 +1220,7 @@ async def test(self) -> None:
         assert entity_one is entity_many.one
 
         entity_one.many.remove(entity_many)
-        assert [] == list(entity_one.many)
+        assert list(entity_one.many) == []
         assert entity_many.one is None
 
 
@@ -1259,8 +1259,8 @@ async def test(self) -> None:
         assert [entity_many] == list(entity_other_many.many)
 
         entity_many.other_many.remove(entity_other_many)
-        assert [] == list(entity_many.other_many)
-        assert [] == list(entity_other_many.many)
+        assert list(entity_many.other_many) == []
+        assert list(entity_other_many.many) == []
 
 
 @many_to_one_to_many(