Conversation
There will be more here later on
Despite the commit size, the change is tiny: - a field in settings (and a listener for changers) - color constants and additional support classes to leverage tailwind's setup
Also carries a fix for the notification filter - now it actually appears if unresolved comments are present.
oddnugget
reviewed
May 19, 2026
| } | ||
| &--highlight&--reviewed { | ||
| @apply bg-chartreuse; | ||
| .dark & { @apply bg-blue-900; } |
Contributor
There was a problem hiding this comment.
You could use the newish light-dark() function here to make it a bit cleaner
| @build_commit_sha_pattern ~r/^[0-9a-f]{40}(\s|$)/ | ||
|
|
||
| def build_commit?(commit) do | ||
| not is_nil(commit.message) && Regex.match?(@build_commit_sha_pattern, commit.message) |
Contributor
There was a problem hiding this comment.
negated is_nil is kind of smelly, better with a is_binary here since thats what is actually required by regex match
| compact = Keyword.get(opts, :compact, false) | ||
|
|
||
| avatar_opts = | ||
| Keyword.delete(opts, :compact) ++ |
Contributor
There was a problem hiding this comment.
Could use a Keyword.pop/3 on L20 to combine get and delete
| defp assign_deployed_shas(socket) do | ||
| repos = socket.assigns.build_commit_repos | ||
|
|
||
| if socket.assigns.features["build_commit_status"] && repos != [] do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small revamp and some additional filtering features:
New design is opt-in with a usage counter.
Screenshots: