Improved attribute handling with types and Attribute support #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix collection attribute typing
…el-ide-helper into barry-backport
Barry backport
…types @fix/collection with template types
Install from scrumble repo
Implemented correct attribute handling
stefanScrumble
changed the title
barryvdh
reviewed
Jul 12, 2024
composer.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "barryvdh/laravel-ide-helper", | |||
| "name": "scrumble-nl/laravel-ide-helper", | |||
|
@mfn what do you think? |
barryvdh
reviewed
Jul 12, 2024
CHANGELOG.md
Outdated
| @@ -80,6 +80,17 @@ All notable changes to this project will be documented in this file. | |||
| - Add support for `immutable_date:*` and `immutable_datetime:*` casts. [#1380 / thekonz](https://github.com/barryvdh/laravel-ide-helper/pull/1380) | |||
| - Add support for attribute accessors marked as protected. [#1339 / pindab0ter](https://github.com/barryvdh/laravel-ide-helper/pull/1339) | |||
|
|
|||
| 2024-01-04, v2.14.0 | |||
| ------------------ | |||
barryvdh
reviewed
Jul 12, 2024
src/helpers/PhpDocTypeParser.php
Outdated
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Barryvdh\LaravelIdeHelper\helpers; |
There was a problem hiding this comment.
Not sure if 'helpers' is appropriate, perhaps something more descriptive like Parsers? But it should follow PSR12 and use StudlyCaps
There was a problem hiding this comment.
Makes sense, fixed! And I Improved the filename to more accurately reflect it's use.
barryvdh
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Properly handle attributes with type templates by parsing the phpdoc and outputting the the ide-helper file with type templates included as FQN.
Handle the Laravel Attribute return type for attribute getters and setters.
Type of change
Checklist
composer fix-style