fix belongsTo relation is detected as nullable. #1461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In ModelsCommand, belongs to relations are detected as nullable when this column is nullable or has not foreign key constraint.
https://github.com/barryvdh/laravel-ide-helper/blob/master/src/Console/ModelsCommand.php#L841-L842
Now read foreign keys is not reset on model loop.
For example. when column x of model A has no foreign key and column x of model B has foreign key, column x of model A may marked as not nullable because column x is recoreded as foreign key by model B.
Type of change
Checklist
composer fix-style