Fetch support #975
Merged
Fetch support #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevelacey
force-pushed
the
fetch-support
branch
from
37e2aeb to
709d593
Compare
|
@barryvdh not sure a tagged release is coming anytime soon given there hasn't been one in 2 years... dare I suggest |
|
Hope for approval soon. Would be cool if I could finally use the debugbar for fetch requests 👍 |
stevelacey
force-pushed
the
fetch-support
branch
from
709d593 to
23db50f
Compare
|
@barryvdh have rebased this, this will make fetch support work by default – and requires the minimum version to up to Can you merge and tag this? 🙏 |
|
Shouldn't it only load to fetch? Won't we get duplicates now? |
|
@barryvdh hm? no? Fetch doesn’t come through as XHR, debugbar is currently oblivious to any fetch based requests |
|
@barryvdh ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for fetch in addition to xhr, depends on: php-debugbar/php-debugbar#422
Most notably (for me anyway) this gets debugbar working in Apollo-based SPA's and GraphiQL.