Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show paths from "vendor/laravel/framework" folder in query traces #695

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Show paths from "vendor/laravel/framework" folder in query traces #695

merged 1 commit into from
Aug 17, 2017

Conversation

aik099
Copy link
Contributor

@aik099 aik099 commented Aug 16, 2017 •
edited
Loading

Before this PR:

  • all paths from "vendor/laravel/framework" folder were removed from query traces making it hard to figure out where a particular query originating from framework code comes from.

After this PR:

  • all files from "vendor/laravel/framework" folder are shown in query traces
  • files from /vendor/laravel/framework/src/Illuminate/Database folder are excluded, because we're not interested in query execution/building
  • files from /vendor/laravel/framework/src/Illuminate/Events folder are excluded, because events are used to monitor actual executed queries and don't trigger any queries themselves

Closes #692

@barryvdh barryvdh merged commit eb8189a into barryvdh:2.4 Aug 17, 2017
@aik099 aik099 deleted the query-backtrace-for-framework-code-feat branch August 17, 2017 11:39
barryvdh pushed a commit that referenced this pull request Aug 28, 2017
@aik099 @barryvdh
Show paths from "vendor/laravel/framework" folder in query traces (#695)
70c2950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aik099 @barryvdh