Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing display in RTL languages #543

Merged
merged 1 commit into from
Feb 13, 2017
Merged

fixing display in RTL languages #543

merged 1 commit into from
Feb 13, 2017

Conversation

boynet
Copy link
Contributor

@boynet boynet commented Sep 5, 2016

see #539

@barryvdh
Copy link
Owner

barryvdh commented Sep 7, 2016

Does this fix it? php-debugbar/php-debugbar#267

@boynet
Copy link
Contributor Author

boynet commented Sep 7, 2016

yes same thing just targeting the root element

@boynet
Copy link
Contributor Author

boynet commented Feb 13, 2017

Hi I think it's got forgotten :) would love to merge this simple fix.

there is really nothing to worry about as it's just reset to default values.
if you don't reset it and you have direction:rtl on the body than its got messed up

see the docs for the default values:
direction
text-align

@barryvdh barryvdh merged commit 0718804 into barryvdh:master Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boynet @barryvdh