fix LogsCollector for default daily logs naming convention in L5 #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laravel 5 defaults to daily log files with the naming convention laravel-2015-04-08.log. updated getLogsFile() method to play nice with this change and default to the daily logs while falling back to the single file logs.
barryvdh
added a commit
that referenced
this pull request
Apr 9, 2015
fix LogsCollector for default daily logs naming convention in L5
|
Thanks for merging this Barry. Much appreciated |
|
And thank you for fixing it :) |
|
No problem! Considering the number of open request i figured you were busy so thought of digging in to try and fix this myself. Will try and dig into the view collector as well since it appears not to play well with Twig bridge and does not show the actual view data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel 5 defaults to daily log files with the naming convention laravel-2015-04-08.log. updated getLogsFile() method to play nice with this change and default to the daily logs while falling back to the single file logs.