Skip to content

Fix QueryCollector #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
barryvdh merged 1 commit into from
Sep 11, 2024
Merged

Fix QueryCollector #1664

barryvdh merged 1 commit into from
Sep 11, 2024

Conversation

@erikn69
Copy link
Contributor

@erikn69 erikn69 commented Sep 11, 2024 •
edited
Loading

  1. Transaction events were being counted as excluded queries, it gave me negative numbers
  2. IMO, transaction events should not be excluded.
  3. Fix Xdebug links no longer worked
  4. IMO, I was just excluding using the name, but it must have been the normalized file path
  5. $totalTime is used to create the timeline waterfall, when it's accumulating but not adding the query, it would not be very close to reality
  6. If the query is not going to be added, other processes such as explain are no longer necessary

@barryvdh barryvdh merged commit 1542461 into barryvdh:master Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erikn69 @barryvdh