-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure session is saved after changing #1573
Conversation
Hi @barryvdh, After updating to the new version and I came from version 3.11 -> 3.12.1. The session flash data isn't available anymore after post -> redirect back to view with flash data. |
Which Laravel version? |
Both 10 and 11's latest releases. I've narrowed it down to the debugbar. After downgrading to 3.11 my form validation etc. worked again. |
Hmm I'l revert for now, not sure why. |
Just the default one:
After reverting it works again. Thanks! |
Tagged a new release |
Curious, do redirects still show in the dropdown in de debugbar? Eg after a POST which redirects, does it show the POST and the GET in the dropdown? |
Thank you! |
They do yes, but just without the flash data Give me 2 seconds, I'll get some screenshots |
@barryvdh I found out why it was not working at my side. In a package I made for our CMS I tried to make sure the ShareErrorsFromSession middleware was in the middleware stack. For some reason this was not a problem in laravel 10 but it is in laravel 11. I tested again with the previous version to make sure it wasn't at the debugbar side. It isn't. Your change was not my problem. But thanks for acting fast! 👍 |
Re-did the same PR with #1591 |
)" (#…" This reverts commit aa9f65b.
Looks like the session isn't properly saved. Not sure if this is Laravel 11 specific or not.
Happens when redirecting.