Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove symfony/debug dependency #1321

Merged
merged 5 commits into from
Jul 11, 2022
Merged

Remove symfony/debug dependency #1321

merged 5 commits into from
Jul 11, 2022

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Jun 9, 2022

Solves #1319

The Class Symfony\Component\Debug\Exception\FatalThrowableError no longer exists, therefor I just removed it and directly throw the Error instead of wrapping it in another Exception.

From Laravel 7 onwards the report and render function also support Throwable instead of only Exception

This may also be a point where support for Laravel 7 can be dropped. (If you want only PHP ^8.0 Support, than it could also be considered to drop Laravel 8)
Laravel 6 gets security fixes until September 6th, 2022
Laravel 8 gets bugfixes until July 26th, 2022, security fixes until January 24th, 2023
See https://laravel.com/docs/9.x/releases#support-policy

How you can test these changes:

{
    "repositories": [
        {
            "type": "git",
            "url": "https://github.com/Jubeki/laravel-debugbar"
        }
    ],
    "require-dev": {
        "barryvdh/laravel-debugbar": "dev-migrate-to-symfony-error-handler"
    },
    "minimum-stability": "dev",
    "prefer-stable": true
}

@AratKruglik
Copy link

Any chances to have this fix soon? )

@barryvdh
Copy link
Owner

barryvdh commented Jul 6, 2022

Is the symfony error handler even required then?

@Jubeki
Copy link
Contributor Author

Jubeki commented Jul 11, 2022

Is the symfony error handler even required then?

I didn't evaluate that. I know that Laravel ships with symfony/error-handler as dependency (See https://github.com/laravel/framework/blob/6dd688461ff7a402efc7f939267087ccafebcc96/composer.json#L35). Therefor, it doesn't matter if it is included or not.

@Jubeki
Copy link
Contributor Author

Jubeki commented Jul 11, 2022

But you are right, the only thing which was used is Symfony\Component\Debug\Exception\FatalThrowableError and there was nothing else. I will remove the symfony/error-handler dependency.

@Jubeki Jubeki changed the title Migrate from symfony/debug to symfony/error-handler Remove symfony/debug dependency Jul 11, 2022
@barryvdh barryvdh merged commit 3372ed6 into barryvdh:master Jul 11, 2022
@barryvdh
Copy link
Owner

Nice, thanks!

@Jubeki Jubeki deleted the migrate-to-symfony-error-handler branch July 11, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants