[Proposal] Add note about possible issues regarding ViewCollector to docs

[splinter89]

When user passes a large number of models to his view,

DataCollector::flattenVar()

may consume too much time/memory.

[barryvdh]

Yeah I was thinking about a way to make this a bit more reliable, like limiting the depth or just displaying what vars are included.

[barryvdh]

Do you have any example where it crashes?

[splinter89]

No, it doesn't crash. I had a situation where passing a lot of models to view doubled execution time of my app. Production code with debug=false worked just fine, so it took me a while to find a reason.
Maybe it would be useful to use Model::toArray() or something similar on models passed to view as it will make the whole process of collecting data faster?
Or just add a simple note to documentation near explanation of ViewCollector? This way others wouldn't waste any time as I did.

[barryvdh]

Yeah or maybe dont display all the data By default, perhaps only the keys or something.

[splinter89]

I just don't know which idea is better..

[barryvdh]

No me neither, I think it is good to warn the users, but it should just
work by default. So when I make it optional, and provide a warning that it
can slow things down, it would be the clearest I guess..
It is already an option btw, but enabled now by default..
Op 11 jan. 2014 21:50 schreef "Anton" notifications@github.com:

I just don't know which idea is better..

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/67#issuecomment-32106643
.

[splinter89]

Providing a simple warning would be great. Thanks!