Skip to content
This repository was archived by the owner on Mar 9, 2024. It is now read-only.

Split patterns for single globs (should be max 260 chars) #6

Merged
merged 2 commits into from
Jun 18, 2015
Merged

Split patterns for single globs (should be max 260 chars) #6

merged 2 commits into from
Jun 18, 2015

Conversation

mmodler
Copy link
Contributor

@mmodler mmodler commented Jun 18, 2015

No description provided.

@barryvdh
Copy link
Owner

Instead of the nested foreach, we could also implode(' ', $rules) them again, to make 1 long string.

And we don't need the BRACE option now, right?

@mmodler
Copy link
Contributor Author

mmodler commented Jun 18, 2015

If we implode with '' we'll get:

...readme*.travis.yml

if we implode with ' ' we might get empty patterns later and have to check for this.

Do you still like to get rid of the bested foreach? :)

@barryvdh
Copy link
Owner

Neh then leave it like this.

This ready?

@mmodler
Copy link
Contributor Author

mmodler commented Jun 18, 2015

Worked for me in my test project

barryvdh added a commit that referenced this pull request Jun 18, 2015
Split patterns for single globs (should be max 260 chars)
@barryvdh barryvdh merged commit 0cd554a into barryvdh:master Jun 18, 2015
@barryvdh
Copy link
Owner

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants