Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only MinGW VSS #1847

Merged
merged 4 commits into from
Jul 1, 2024
Merged

Use only MinGW VSS #1847

merged 4 commits into from
Jul 1, 2024

Conversation

tuxmaster5000
Copy link
Contributor

@tuxmaster5000 tuxmaster5000 commented Jun 6, 2024

Fix #1843

Please check

  • Short description and the purpose of this PR is present above this paragraph
    Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@arogge arogge self-assigned this Jun 6, 2024
@arogge arogge requested a review from sebsura June 11, 2024 10:14
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work pretty well so far. Thank you!

There are three things that should be addressed before we can merge this pull request.

rename the header to vss_client.h

calling it vss_client.h would align its name with its content, which is mainly class VssClient.

fix include guard in header

the include guard (for the renamed header) should be BAREOS_WIN32_INCLUDE_VSS_CLIENT_H_

update copyright years in changed files

the copyright header of the files you changed still states the latest update was 2023. Even for minor changes the year needs to be updated.

@arogge arogge added this to the 24.0.0 milestone Jun 25, 2024
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your work!

@BareosBot BareosBot merged commit 20f080d into bareos:master Jul 1, 2024
@tuxmaster5000 tuxmaster5000 deleted the vss branch July 1, 2024 17:40
This was referenced Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[23.0.3] build failed for Windows
4 participants