-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use only MinGW VSS #1847
Use only MinGW VSS #1847
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work pretty well so far. Thank you!
There are three things that should be addressed before we can merge this pull request.
rename the header to vss_client.h
calling it vss_client.h
would align its name with its content, which is mainly class VssClient
.
fix include guard in header
the include guard (for the renamed header) should be BAREOS_WIN32_INCLUDE_VSS_CLIENT_H_
update copyright years in changed files
the copyright header of the files you changed still states the latest update was 2023. Even for minor changes the year needs to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for your work!
Co-authored-by: Andreas Rogge <andreas.rogge@bareos.com>
Fix #1843
Please check
Your name is present in the AUTHORS file (optional)If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-tool
to have some simple automated checks run and a proper changelog record added.General
Source code quality