Fix: handle the PREFIX directory creation #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the target directory creation while works will need checks and might create symlinks instead of the directory on certain cases, thus the need for a note
barelyhuman
force-pushed
the
fix/mkdir-prefix-path
branch
from
60846bb to
f8a0933
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be cases where the prefixed directory might not exist and the
installcommand will fail silently and doesn't make much sense as it abstracts the debugging info.The PR tries to fix that by making sure the user has perms to create the
PREFIXdirectory and creates it for them , CI environments should theoretically be able to handle the permissions by default but still needs a viable test before confirming that (add it as a url feature flag to check this without breaking existing usecases)