Improve scaling behavior

[pgilfernandez]

While working on the macOS support I feel like the scaling behavior is not natural so this is what I did:

• Corner handles honor the “Fixed Ratio” preference by default; holding Shift inverts that preference (locked → freeform, freeform → locked).
• Edge (side) handles always do non-proportional scaling, regardless of Shift or the "Fixed Ratio" toggle.
• The "Fixed Ratio" toggle in the properties panel now shares its state with the 2D canvas so both UI and drag interactions stay consistent.

Try it and let me know if you like it 😄

[knipknap]

Sorry, this one flew under my radar, the notification got lost in other mails. Unfortunately the code base has moved so much that the PR no longer applies.

In general, I tried to replicate the behavior of the Inkscape canvas. To me it would seem unexpected if the corner handles force aspect ratio by default - Inkscape does not follow this semantic, enabling forced aspect only through modifier keys.

Otherwise I think resolving the conflict between the aspect toggle in the properties and the mouse behavior is a good idea.

[pgilfernandez]

Hi!

Well, don't worry, here you have the idea in case you want to implement it.

I understand that you were trying to replicate Inkscape behavior but think that it is a design software where it's normal to transform, deform, etc. your vectors while Rayforge is focused on burning so it is supposed that vector will get imported in their final sizes and, if the case, users will probably want to proportionally scale but not deform the designs.... don't you think?

That's why I turned the default to proportionally scale 😉

[RobinWhitfield]

Just adding that I do think that you'd expect resizing to maintain aspect ratio by default.

It's caught me out a couple of times already.

[knipknap]

I think it depends on what other software you use. I would definitely get tripped up by locked aspect, I have never used any software that does - it appears the majority locks aspect only with a modifier key.

Though IMO a strong argument is that Lightburn locks aspect by default, where many users may be coming from...

[RobinWhitfield]

I would definitely get tripped up by locked aspect

When you say tripped up, what do you mean? Do you mean that you'd instinctively hold shift and have it not maintain the aspect ratio?
As there are side drag controls to me at least it feels mostly superfluous even letting a corner drag affect the aspect.

On a related note, I'd expect the "Fixed Ratio" toggle on the right to affect this, and not just the numerical values. Maybe "Maintain Aspect Ratio" would be a better wording too - perhaps with a "reset to original aspect ratio" adjacent to the toggle in case you accidentally adjust it.

If you think that some people would want it reversed (as it is right now), perhaps that could be a software preference that will default the above mentioned toggle to whatever the software preference is. But I think I'd still have it fixed by default.