Skip to content

Add RINEX output, and fix some issues #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

EmmanuelMess
Copy link

@EmmanuelMess EmmanuelMess commented Jun 23, 2025

  • Fixed a crash when no files to share available
  • Added RINEX observations file
  • Added RINEX navigations file and parsing

  • Acknowledge that you're contributing your code under Apache v2.0 license

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2025

CLA assistant check
All committers have signed the CLA.

@EmmanuelMess
Copy link
Author

I have phantom observations that are marked as year 2048 for some reason, and only come from NAVSTAR. And I cannot seem to be able to receive ephemeris to test the RINEX yet.

@EmmanuelMess EmmanuelMess force-pushed the emmanuelmess/feature/rinex branch from f4af378 to b1a440c Compare June 23, 2025 15:43
@EmmanuelMess EmmanuelMess force-pushed the emmanuelmess/feature/rinex branch 4 times, most recently from 48469f8 to 840dab6 Compare June 23, 2025 23:46
@EmmanuelMess
Copy link
Author

Okay, I will add a check to see when the fix is obtained, because clocks before that appear broken. @barbeau please run the CI to see if the tests pass.

@EmmanuelMess EmmanuelMess force-pushed the emmanuelmess/feature/rinex branch from 840dab6 to c0bb617 Compare June 24, 2025 12:52
@EmmanuelMess EmmanuelMess marked this pull request as ready for review July 1, 2025 21:56
@barbeau
Copy link
Owner

barbeau commented Jul 26, 2025

@EmmanuelMess While I appreciate your work on this, I have to say that I'm a bit hesitant to accept this contribution, primarily because I've spent a lot of time maintaining the RINEX file format for GnssLogger, and it's not trivial. I really don't have the bandwidth to take on maintaining another implementation of a RINEX file writer.

Maybe you could split off this contribution into a separate project to convert from the txt format to RINEX? I know there are a few such projects that exist, but I don't have any idea of how well they perform.

@EmmanuelMess
Copy link
Author

@barbeau Any recommendations on under what framework the tool should be built? I fear there will be issues to run it.

The emulator execution in CI should be taken out and made a separate PR then.

@barbeau
Copy link
Owner

barbeau commented Jul 30, 2025

Any recommendations on under what framework the tool should be built?

I think most of the code in the PR is in kotlin? If so it should be pretty easy to convert this into a Java/Kotlin command line tool. If you don't want to host it in a separate GitHub repository, we could put it under a different module in this project - I would be ok with that. In particular, I'm not sure if there is a navigation message txt to RINEX conversion tool out there - IIRC most of the tools I've seen are for observations.

The emulator execution in CI should be taken out and made a separate PR then

Yes, that would be great if you could split that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants