Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licensei cache #906

Closed
wants to merge 1 commit into from
Closed

Licensei cache #906

wants to merge 1 commit into from

Conversation

nishantapatil3
Copy link
Contributor

@nishantapatil3 nishantapatil3 commented Mar 3, 2023

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets fixes random licensei check failures
License Apache 2.0

What's in this PR?

Add licensei.cache file to skip pre-resolved detection failures

Why?

licensei check fails randomly sometimes when github repo license could not be determined

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)

@nishantapatil3 nishantapatil3 changed the base branch from release-1.17 to release-1.15 March 3, 2023 21:41
@nishantapatil3 nishantapatil3 force-pushed the licensei_cache branch 2 times, most recently from 0875904 to 024e9e9 Compare March 5, 2023 19:37
@nishantapatil3
Copy link
Contributor Author

Alternative solution #907 , if using go mod vendor is acceptable we can close this PR #906

@nishantapatil3
Copy link
Contributor Author

Closing this PR as #907 is approved and merged

@nishantapatil3 nishantapatil3 deleted the licensei_cache branch March 8, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant