Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a protobuf fork for int64/uint64 as int marshaling support #868

Merged
merged 4 commits into from
Sep 14, 2022
Merged

add a protobuf fork for int64/uint64 as int marshaling support #868

merged 4 commits into from
Sep 14, 2022

Conversation

LuciferInLove
Copy link
Collaborator

@LuciferInLove LuciferInLove commented Sep 13, 2022 •
edited
Loading

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets
License Apache 2.0

int64/uint64 as int marshaling support for the updated protobuf

@LuciferInLove LuciferInLove marked this pull request as draft September 13, 2022 22:39
@LuciferInLove LuciferInLove marked this pull request as ready for review September 14, 2022 08:43
pregnor
pregnor reviewed Sep 14, 2022
View reviewed changes
Copy link
Member

@pregnor pregnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm no expert here

scripts/download-deps.sh Show resolved Hide resolved
nishantapatil3
nishantapatil3 approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@nishantapatil3 nishantapatil3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@LuciferInLove LuciferInLove merged commit cd809ab into release-1.15 Sep 14, 2022
@LuciferInLove LuciferInLove deleted the protobuf_fork branch September 14, 2022 15:16
@Laci21 Laci21 mentioned this pull request Sep 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pregnor pregnor pregnor left review comments

@nishantapatil3 nishantapatil3 nishantapatil3 approved these changes

@martonsereg martonsereg Awaiting requested review from martonsereg martonsereg is a code owner

@waynz0r waynz0r Awaiting requested review from waynz0r waynz0r is a code owner

@Laci21 Laci21 Awaiting requested review from Laci21 Laci21 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuciferInLove @pregnor @nishantapatil3