Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #808 #809

Merged
merged 3 commits into from
Jan 24, 2022
Merged

Fix #808 #809

merged 3 commits into from
Jan 24, 2022

Conversation

Tanemahuta
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
API breaks? no
Deprecations? no
Related tickets fixes #808
License Apache 2.0

What's in this PR?

Improved matcher for supported istio versions

Why?

IstioControlPlane was not usable setting 1.11 as version.

Checklist

  • [ X ] Implementation tested
  • [ X ] Error handling code meets the guideline (N/A)
  • [ X ] Logging code meets the guideline (N/A)
  • [ X ] User guide and development docs updated (if needed) (N/A)

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Laci21
Laci21 reviewed Jan 21, 2022
View reviewed changes
controllers/version.go Outdated Show resolved Hide resolved
waynz0r
waynz0r approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@waynz0r waynz0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @Tanemahuta!

@Laci21 Laci21 merged commit d1a174a into banzaicloud:release-1.11 Jan 24, 2022
@Laci21
Copy link
Member

Laci21 commented Jan 24, 2022

Thank you very much @Tanemahuta for your contribution!

@Tanemahuta
Copy link
Contributor Author

Thank you very much @Tanemahuta for your contribution!

It was my pleasure, thanks for your help with the problems I had!

@Laci21 Laci21 mentioned this pull request Jan 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Laci21 Laci21 Laci21 left review comments

@waynz0r waynz0r waynz0r approved these changes

@martonsereg martonsereg Awaiting requested review from martonsereg martonsereg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tanemahuta @CLAassistant @Laci21 @waynz0r