Skip to content

Fixing default javascripts/stylesheets-path values - #7

Merged
banyan merged 2 commits into
banyan:masterfrom
purew:master
Jun 6, 2020
Merged

Fixing default javascripts/stylesheets-path values#7
banyan merged 2 commits into
banyan:masterfrom
purew:master

Conversation

@purew

@purew purew commented Sep 13, 2016

Copy link
Copy Markdown
Contributor

A fresh brunch-project places js/css-files in public/. The default values in gzip-brunch don't match this.

A fresh brunch-project places js/css-files in public. The default values in gzip-brunch don't match this.
@banyan

banyan commented Jun 6, 2020

Copy link
Copy Markdown
Owner

@purew

sorry for late. Thanks!

@banyan
banyan merged commit 503b5ec into banyan:master Jun 6, 2020
@banyan

banyan commented Jun 6, 2020

Copy link
Copy Markdown
Owner

Released as 2.0.0.

@reubano

reubano commented Jul 22, 2020

Copy link
Copy Markdown
Contributor

Not sure how this helps. Now there is no default js or css path and the plugin is broken. The previous version looked in the public folder already. The default values were the subfolder to look in, inside the public folder. Also, this change invalidates the default folder locations listed in the readme.

@reubano

reubano commented Jul 22, 2020

Copy link
Copy Markdown
Contributor

Please revert this commit.

@reubano

reubano commented Jul 22, 2020

Copy link
Copy Markdown
Contributor

E.g., now you must set the config, whereas before you didn't need to.

module.exports = {
  plugins: {
    gzip: {
      paths: {
        javascript: 'javascripts',
        stylesheet: 'stylesheets'
      }
    },
  ...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants