Skip to content

Replace Keycloak role converter with standard Spring converter #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ewoerner wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −38
Open

Replace Keycloak role converter with standard Spring converter #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions src/main/java/com/bannergress/backend/security/KeycloakRealmRoleConverter.java
View file
Open in desktop

This file was deleted.

11 changes: 2 additions & 9 deletions src/main/java/com/bannergress/backend/security/KeycloakSecurityConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
import org.springframework.context.annotation.Configuration;
import org.springframework.context.annotation.Profile;
import org.springframework.http.HttpHeaders;
import org.springframework.security.config.Customizer;
import org.springframework.security.config.annotation.method.configuration.EnableMethodSecurity;
import org.springframework.security.config.annotation.web.builders.HttpSecurity;
import org.springframework.security.config.annotation.web.configurers.CsrfConfigurer;
import org.springframework.security.config.annotation.web.configurers.HeadersConfigurer;
import org.springframework.security.config.annotation.web.configurers.HeadersConfigurer.CacheControlConfig;
import org.springframework.security.oauth2.server.resource.authentication.JwtAuthenticationConverter;
import org.springframework.security.web.SecurityFilterChain;
import org.springframework.security.web.header.writers.StaticHeadersWriter;

Expand All @@ -23,8 +23,7 @@ SecurityFilterChain filterChain(HttpSecurity http) throws Exception {
return http //
.csrf(CsrfConfigurer::disable) //
.headers(this::customizeHeaders)
.oauth2ResourceServer(
oauth2 -> oauth2.jwt(jwt -> jwt.jwtAuthenticationConverter(jwtAuthenticationConverter()))) //
.oauth2ResourceServer(oauth2 -> oauth2.jwt(Customizer.withDefaults())) //
.authorizeHttpRequests(auth -> auth.anyRequest().permitAll()) //
.build();
}
Expand All @@ -34,10 +33,4 @@ private HeadersConfigurer<HttpSecurity> customizeHeaders(HeadersConfigurer<HttpS
.cacheControl(CacheControlConfig::disable)
.addHeaderWriter(new StaticHeadersWriter(HttpHeaders.CACHE_CONTROL, "must-revalidate"));
}

private JwtAuthenticationConverter jwtAuthenticationConverter() {
JwtAuthenticationConverter jwtConverter = new JwtAuthenticationConverter();
jwtConverter.setJwtGrantedAuthoritiesConverter(new KeycloakRealmRoleConverter());
return jwtConverter;
}
}
7 changes: 2 additions & 5 deletions src/main/resources/application.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,8 @@ spring:
resourceserver:
jwt:
issuer-uri: ${keycloak.auth-server-url}/realms/${keycloak.realm}

keycloak:
bearer-only: true
authority-prefix: ROLE_
authorities-claim-name: roles

springdoc:
paths-to-match:
Expand All @@ -55,8 +54,6 @@ server:

spring:
config.activate.on-profile: dev
keycloak:
enabled: false

logging:
level:
Expand Down