Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cover image event field and complete info event list #42

Merged
merged 7 commits into from
Jan 8, 2024

Conversation

fikrialwan
Copy link
Contributor

@fikrialwan fikrialwan commented Jan 6, 2024

What kind of change does this PR introduce?

  • Add cover image event field
  • complete info event list

What is the current behavior?

Current behavior can't update cover image event
Screen Shot 2024-01-06 at 21 12 06

Current behavior info event list only title description and date
Screen Shot 2024-01-06 at 21 17 12

What is the new behavior?

New behavior user can update cover image event
Screen Shot 2024-01-06 at 21 10 47

New behavior with date time and location on event item list
Screen Shot 2024-01-06 at 21 56 05

$nbsp;
$nbsp;
Related to Close #33 and Close #34

Copy link

vercel bot commented Jan 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bandungdev-com ✅ Ready (Inspect) Visit Preview Jan 8, 2024 1:29pm

@fikrialwan fikrialwan marked this pull request as ready for review January 6, 2024 14:20
@fikrialwan fikrialwan marked this pull request as draft January 6, 2024 14:25
@fikrialwan fikrialwan marked this pull request as ready for review January 6, 2024 15:00
@mhaidarhanif mhaidarhanif self-requested a review January 6, 2024 23:27
@mhaidarhanif mhaidarhanif added the enhancement New feature or request label Jan 6, 2024
Copy link
Member

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fikrialwan I've added some comments to improve, please check.

@fikrialwan
Copy link
Contributor Author

@mhaidarhanif I've resolve all feedback, can you review again my changes

Copy link
Member

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@mhaidarhanif mhaidarhanif merged commit 33ca0eb into staging Jan 8, 2024
1 check passed
@mhaidarhanif mhaidarhanif deleted the event-image-upload-and-event-list branch January 8, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event list complete info Event upload cover image
3 participants