-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cover image event field and complete info event list #42
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fikrialwan I've added some comments to improve, please check.
@mhaidarhanif I've resolve all feedback, can you review again my changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good
What kind of change does this PR introduce?
What is the current behavior?
Current behavior can't update cover image event
![Screen Shot 2024-01-06 at 21 12 06](https://private-user-images.githubusercontent.com/26239542/294695698-bb220e07-64c1-437e-95f2-9d88971f6bb3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MDg3NjcsIm5iZiI6MTczODkwODQ2NywicGF0aCI6Ii8yNjIzOTU0Mi8yOTQ2OTU2OTgtYmIyMjBlMDctNjRjMS00MzdlLTk1ZjItOWQ4ODk3MWY2YmIzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDA2MDc0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM2MzQ1NmE2ZTNkZWIyOWUxZjFjYTVhMzBhOTMxNjExZGNkMzJlMjZlMmQyZjgxMDkzN2M2NGMxZDJhYmMzYmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.WO1do9cy8EMZ8KymR2fUVU9hKDa8YNBKSJfudfByASs)
Current behavior info event list only title description and date
![Screen Shot 2024-01-06 at 21 17 12](https://private-user-images.githubusercontent.com/26239542/294695767-845b1253-6903-4f47-919b-d528c278adbc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MDg3NjcsIm5iZiI6MTczODkwODQ2NywicGF0aCI6Ii8yNjIzOTU0Mi8yOTQ2OTU3NjctODQ1YjEyNTMtNjkwMy00ZjQ3LTkxOWItZDUyOGMyNzhhZGJjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDA2MDc0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA2ZjhlMzE1OTU3NDk1MTNjMDg1OTI2MDY5Nzk4YjFiYTE5ZmI4M2UxMWExNzJlOTVmYjYwMjVlYTA4OGI0NmUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.mL9iQ2qDgZrdEnsImPrdl5XuIAhm7_SFoPk_fB6NIQE)
What is the new behavior?
New behavior user can update cover image event
![Screen Shot 2024-01-06 at 21 10 47](https://private-user-images.githubusercontent.com/26239542/294695828-e36883d4-91cd-4e69-a518-d6f216767475.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MDg3NjcsIm5iZiI6MTczODkwODQ2NywicGF0aCI6Ii8yNjIzOTU0Mi8yOTQ2OTU4MjgtZTM2ODgzZDQtOTFjZC00ZTY5LWE1MTgtZDZmMjE2NzY3NDc1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDA2MDc0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY3YjE0Yjg1MWNhY2JhMGI2ZDdjMmY3ODZhMGQ1MWZiNWE0NDRmMzM3ZWM5MzZjZjgwZDBjNmJhOWU5ZDA0ZjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Gh9YAhwAxDKFyzCNkSninpq-ms8ms-RLeX2reQwA5u8)
New behavior with date time and location on event item list
![Screen Shot 2024-01-06 at 21 56 05](https://private-user-images.githubusercontent.com/26239542/294697942-06980b21-15e7-4f73-a33c-43732d7706a7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MDg3NjcsIm5iZiI6MTczODkwODQ2NywicGF0aCI6Ii8yNjIzOTU0Mi8yOTQ2OTc5NDItMDY5ODBiMjEtMTVlNy00ZjczLWEzM2MtNDM3MzJkNzcwNmE3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDA2MDc0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM3ZjFlNWYwNTE1MGQ4N2FmMGYzOWQ5ZjE3MjQzM2VjZGY2M2M5NzUxYmVjMWY1ODNmY2YzNDBjMWM3ZTAwODkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.bssQZC2Xg_IU7n_YiqHd_4C8sf43y4ErcDsud8cPOyI)
$nbsp;
$nbsp;
Related to Close #33 and Close #34