Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Location and related models #23

Merged
merged 44 commits into from
Dec 30, 2023
Merged

Event Location and related models #23

merged 44 commits into from
Dec 30, 2023

Conversation

fikrialwan
Copy link
Contributor

@fikrialwan fikrialwan commented Dec 24, 2023

What kind of change does this PR introduce?

Create function and UI to add event location when create event.

Event Location is available if the Category is In Person.

  • Create schema and seed data location categories
  • Create UI add event location
  • Create function to add event location
  • Show event location on event page detail

What is the current behavior?

Screen Shot 2023-12-24 at 14 34 10   Screen Shot 2023-12-24 at 14 36 59  

What is the new behavior?

Screen Shot 2023-12-29 at 15 43 24 new behaviour when create and update events   Screen Shot 2023-12-29 at 23 47 37 Screen Shot 2023-12-29 at 23 50 15 Screen Shot 2023-12-29 at 23 51 10

new behaviour event page

 
 
Closes #5

Copy link

vercel bot commented Dec 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandungdev-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2023 3:40pm

@fikrialwan fikrialwan added the enhancement New feature or request label Dec 24, 2023
@mhaidarhanif mhaidarhanif changed the title Event Location Event Location and related models Dec 25, 2023
@mhaidarhanif
Copy link
Member

@fikrialwan and @babdurrahman78 can use the same existing branch to work together, no need to create a separated branch.

@fikrialwan
Copy link
Contributor Author

@mhaidarhanif this pull request is ready now, for review together, I possible tonight

@fikrialwan fikrialwan marked this pull request as ready for review December 29, 2023 23:55
Copy link
Member

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fikrialwan @babdurrahman78

  • Fix import to use ~ such as ~/components
  • Remove organizerId requirement in model admin event
  • Fix layout to edit the detail to be simpler in the middle
  • Event Category radio button background color
  • Event page to move Category to below Format, with just a text
  • Rename Location (Offline) to Location (In Person)
  • Show Maps URL below Location In Person
  • Fix render if location is null
  • Don't show Format and Category label if the data is unavailable

@fikrialwan
Copy link
Contributor Author

@mhaidarhanif
I've done fix all of the feedback

  • Fix import to use ~ such as ~/components 41dd8e9
  • Remove organizerId requirement in model admin event 9af66ed
  • Fix layout to edit the detail to be simpler in the middle 81f6ef8
  • Event Category radio button background color 32d9773
  • Event page to move Category to below Format, with just a text 9658643
  • Rename Location (Offline) to Location (In Person) c54ee41
  • Show Maps URL below Location In Person 35aea5d
  • Fix render if location is null ae004eb
  • Don't show Format and Category label if the data is unavailable 04dd87c

@mhaidarhanif mhaidarhanif merged commit 80540d0 into staging Dec 30, 2023
1 check passed
@bandungdev-com bandungdev-com deleted the event-location branch January 3, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Event info with location
3 participants