add band liveliness logic #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 20, 2024 12:27
RogerKSI
reviewed
Jan 2, 2025
| @@ -8,5 +8,6 @@ penalty_exponential_factor = 1.0 | |||
| [bandchain] | |||
| rpc_endpoints = ['http://localhost:26657'] | |||
| timeout = 3000000000 | |||
| liveliness_checking_interval = 900000000000 | |||
There was a problem hiding this comment.
I think the liveliness internal should be quite fast at most (<=5m / <=1m) for both the band side and the chain side because we don't have the logic to switch nodes if it fails. the program will stuck until the next interval.
@tanut32039 @nkitlabs what do you think?
anyway, please test on fast intervals as well. to make sure that we don't have an issue if the node switches in the middle of the process.
There was a problem hiding this comment.
the default interval can be reduced.
nkitlabs
reviewed
Jan 6, 2025
relayer/band/client.go
Outdated
Comment on lines
134
to
135
| if err := c.connect(timeout); err != nil { | ||
| c.Log.Error("Liveliness check: unable to reconnect to any endpoints", zap.Error(err)) |
There was a problem hiding this comment.
Selected rpc from startLivenessCheck should be active.
- suggest solution check status inside the connect function if required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #XXXX
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)