[Fix] Patch minor #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkitlabs
requested review from
RogerKSI and
tanut32039
and removed request for
RogerKSI
RogerKSI
reviewed
Dec 17, 2024
tanut32039
reviewed
Dec 27, 2024
| @@ -78,12 +83,6 @@ func (c *client) Connect(timeout uint) error { | |||
| continue // Try the next endpoint if there's an error | |||
| } | |||
|
|
|||
| // Start the client to establish a connection | |||
There was a problem hiding this comment.
Even we use unavailable endpoints,c.Log.Info("Connected to Band chain", zap.String("endpoint", rpcEndpoint)) will be logged. Is it weird ?
There was a problem hiding this comment.
not logging that na, or i miss sth?
There was a problem hiding this comment.
per discussed, not check active rpc on starting up the program.
tanut32039
approved these changes
Jan 3, 2025
RogerKSI
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)