[Feature] - add prompt #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerKSI
approved these changes
Dec 9, 2024
nkitlabs
reviewed
Dec 11, 2024
cmd/keys.go
Outdated
Comment on lines
60
to
62
| huh.NewOption(privateKeyLabel, privateKeyLabel), | ||
| huh.NewOption(mnemonicLabel, mnemonicLabel), | ||
| huh.NewOption(defaultLabel, defaultLabel), |
There was a problem hiding this comment.
Should key and value be the same (long string)?
cmd/keys.go
Outdated
Comment on lines
130
to
131
| cmd.Flags().Int32(flagCoinType, -1, "Coin type number for HD derivation") | ||
| cmd.Flags().Uint(flagAccount, 0, "Account number within the HD derivation path") |
There was a problem hiding this comment.
these are used only in creating new keys? should we add it in the default section instead of flag; ask @RogerKSI
nkitlabs
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #XXXX
Implementation details
Add options for user in command prompt when call
falcon keys add ...If inserting private key
If inserting mnemonic
If generating new address
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)