Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch to Cosmos v0.44.0 #173

Merged
merged 6 commits into from
Sep 6, 2021
Merged

patch to Cosmos v0.44.0 #173

merged 6 commits into from
Sep 6, 2021

Conversation

Benzbeeb
Copy link
Contributor

@Benzbeeb Benzbeeb commented Sep 2, 2021 •
edited
Loading

Implementation details

  • (bump) Use cosmos-sdk package v0.44.0
  • (bump) Use ibc-go package v1.1.0

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

p-rial
p-rial approved these changes Sep 3, 2021
View reviewed changes
go.sum Outdated Show resolved Hide resolved
taobun
taobun requested changes Sep 3, 2021
View reviewed changes
Copy link
Member

@taobun taobun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kissadada
Kissadada approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@Kissadada Kissadada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yoda/execute.go Show resolved Hide resolved
taobun
taobun requested changes Sep 6, 2021
View reviewed changes
Copy link
Member

@taobun taobun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update changelog and PR description

@Benzbeeb Benzbeeb requested a review from taobun September 6, 2021 04:00
taobun
taobun requested changes Sep 6, 2021
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@Benzbeeb Benzbeeb requested a review from taobun September 6, 2021 04:21
taobun
taobun approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@taobun taobun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taobun taobun merged commit 4fe1963 into master Sep 6, 2021
@taobun taobun deleted the patch-to-0.44.0 branch September 6, 2021 04:24
vuong177 pushed a commit to vuong177/chain that referenced this pull request Feb 5, 2022
@dependabot @colin-axner
Bump actions/checkout from 2 to 2.3.4 (bandprotocol#173)
9c16e45 
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 2.3.4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v2.3.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-rial p-rial p-rial approved these changes

@taobun taobun taobun approved these changes

@songwongtp songwongtp songwongtp approved these changes

@Kissadada Kissadada Kissadada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Benzbeeb @Kissadada @songwongtp @taobun @p-rial