[Interactive Chart] Zoom & Pan #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying carbon-app-blast with
|
| Latest commit: |
a52dc25
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f38636b6.carbon-app-blast.pages.dev |
| Branch Preview URL: | https://issue--1504.carbon-app-blast.pages.dev |
Deploying carbon-app with
|
| Latest commit: |
a52dc25
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dda1f4a5.carbon-app-csq.pages.dev |
| Branch Preview URL: | https://issue--1504.carbon-app-csq.pages.dev |
Deploying carbon-app-celo with
|
| Latest commit: |
a52dc25
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c5cf8046.carbon-app-celo.pages.dev |
| Branch Preview URL: | https://issue--1504.carbon-app-celo.pages.dev |
Deploying carbon-app-sei with
|
| Latest commit: |
a52dc25
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://61ef3460.carbon-app-sei.pages.dev |
| Branch Preview URL: | https://issue--1504.carbon-app-sei.pages.dev |
reference: |
tiagofilipenunes
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Nice update! Zoom and pan look and feel great! Pointer also looks great and locks well to the xTicks when zoomed in.
Some notes
- I think this behaviour is okay but just flagging:
- When both range values are 0 (looks better like this imo)
- When only one of the range values is non-zero, the chart looks as
2. Might be worth adding an issue to add support to mobile zoom & pan @Costa769
e2e/screenshots/simulator/recurring/Recurring_limit_limit/simulator-input-price.png
Outdated
Show resolved
Hide resolved
src/components/strategies/common/d3Chart/D3ChartCandlesticks.tsx
Outdated
Show resolved
Hide resolved
tiagofilipenunes
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1504