React native 0.78 compatibility

[cristiammercado]

Describe the bug
Hi,

I'm in the process of migrating to React Native 0.78.0 and React 19, and there appear to be compatibility issues with the library in version 5.1.1.

To Reproduce

import {Directions, SpatialNavigation} from 'react-tv-space-navigation';

import {LoggerService} from './logger.service.ts';
import {remoteControlService} from './remote-control.service.ts';
import {SupportedKeysEnum} from '../model/enums/supported-keys.enum.ts';

export class SpatialNavigationService {

  private constructor() {
  }

  public static init(): void {
    SpatialNavigation.configureRemoteControl({
      remoteControlSubscriber: (callback) => {
        const mapping: { [key in SupportedKeysEnum]: Directions | null } = {
          [SupportedKeysEnum.Right]: Directions.RIGHT,
          [SupportedKeysEnum.Left]: Directions.LEFT,
          [SupportedKeysEnum.Up]: Directions.UP,
          [SupportedKeysEnum.Down]: Directions.DOWN,
          [SupportedKeysEnum.Enter]: Directions.ENTER,
          [SupportedKeysEnum.Back]: null
        };

        const remoteControlListener = (keyEvent: SupportedKeysEnum): void => callback(mapping[keyEvent]);

        return remoteControlService.addKeydownListener(remoteControlListener);
      },
      remoteControlUnsubscriber: (remoteControlListener): void => {
        remoteControlService.removeKeydownListener(remoteControlListener);
      },
    });

    LoggerService.info(`[SpatialNavigationService] Initialized spatial navigation service on TV`);
  }

}

<SpatialNavigationDeviceTypeProvider>
  <SpatialNavigationRoot isActive={true}>
    <SpatialNavigationView direction='vertical' style={styles.container}>
      <MyAppComponent/>
    </SpatialNavigationView>
  </SpatialNavigationRoot>
</SpatialNavigationDeviceTypeProvider>

Expected behavior
Application continues to work as it normally did in previous versions of React native (in my case 0.76.5).

Screenshots

Version and OS

• Library version: 5.1.1
• React Native version: 0.78.0
• OS: Android

Additional context
Add any other context about the problem here.

[cristiammercado]

Hi @pierpo, any update about this?

[samsonroy]

Hi @pierpo any update on this ?

[vishu2124]

@pierpo - Any update on this, We are having issue with RN version 0.78, I'm in the process of migrating to React Native 0.78.0 and React 19, and there appear to be compatibility issues with the library.

[pierpo]

Hey! Sorry for not being very active on the project right now 😅
Could you help with the investigation? I do not have any time to look at it myself 😭 I'll make some time to review PRs and publish changes, but it would be lovely to get some help regarding the solution!

[robmim]

@pierpo , The React and React-dom version seem to cause this issue. Since the latest version of expo and react-native are using version 19 and SpatialNavigation is using 18.

"@types/react": "~18.2.79",
"@types/react-dom": "~18.2.25",

[robmim]

@pierpo Just made a PR for this. Everything is building fine but the mapping of the remote control inst working now. Why i dont know.

#185

[pierpo]

Awesome @robmim 🙌 I will have a look!
Sorry about the very long delay, I was off the whole month!

[fuecco]

Any update on this @robmim @pierpo ?

[robmim]

@fuecco I strongly recommend you to use react-native-tv-os instead of this librairy if you need to go forward with your project.

There is plenty of demo and sample project you can based your project on.

https://github.com/react-native-tvos/react-native-tvos/wiki

[fuecco]

Any reason for not recommending this library? Do you see any issues/shortcomings?

[robmim]

I'm simply saying that if you need to go forward you should think about using something else. Putting pressure on Pierre or me to fix issues you have doesn't help anyone here. If you want to contribute and help us you are more than welcome to edit code, add pr, find bugs.