Fix InputStream resource leak in ImageResizer.getOrientationMatrix()
#423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Resource leak in
ImageResizer.getOrientationMatrix()
Problem
The
InputStream
opened ingetOrientationMatrix()
was not being properly closed, causing a resource leak.We discovered this when we turned on StrictMode on our Android app to trace memory related problems:
Solution
Wrapped the
InputStream
in a try-with-resources statement to ensure automatic resource cleanup.Changes
android/src/main/java/com/reactnativeimageresizer/ImageResizer.java
line 322-324InputStream
management to try-with-resources patternImpact
Testing