Fix a faulty setState call when container could be unmounted in future #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, we have been using this great library but there is a issue when you use
HeaderImageScrollView
inside aView
that also hasonLayout
callback attached then rotating the device will cause the error to come up in React-Native warning box stating thatsetState
can't be used on unmounted component.This is happening because:
The actual callback with
this.setState
call might indeed happen when the component is unmounted.Therefore I have added additional guard inside that callback to make sure that
setState
won't fire ifcontainer
does not exist anymore.