Skip to content

Important ! Listener is not removed #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Important ! Listener is not removed #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Important ! Listener is not removed 
There is no ID for the new listener so actually when the component is updated it keeps creating new listeners.
  • Loading branch information
@jr-k
jr-k authored Mar 19, 2018
commit 9a36a78eb8b8cc34399ae2b7a8fb7a6365ee60ea
2 changes: 1 addition & 1 deletion src/TriggeringView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class TriggeringView extends Component<Props, State> {
return;
}
this.context.scrollY.removeListener(this.listenerId);
nextContext.scrollY.addListener(this.onScroll);
this.listenerId = nextContext.scrollY.addListener(this.onScroll);
}

onRef = (ref: any) => {
Expand Down