This repository was archived by the owner on Jul 28, 2022. It is now read-only.
Fixing missing check for active catalyst instance on react context #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minishlink
approved these changes
Jan 23, 2022
| } | ||
| reactContext | ||
| .getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class) | ||
| .emit(eventName, params); |
Contributor
There was a problem hiding this comment.
Does it crash here? If so there might be a bug in RN and we should open an issue on their repo
| @Nullable WritableMap params) { | ||
|
|
||
| if (!reactContext.hasActiveCatalystInstance()) { | ||
| Log.d(NAME, "React context has no active catalyst instance. Aborting send event."); |
Contributor
There was a problem hiding this comment.
Ideally we would store the event, and send it later once react gets an active catalyst instance
Otherwise you lose the event :/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have users who have a crash while opening their app from a push notification. Actually the event dispatcher added in the recent versions, try to access the module before the React instance be fully set up.