Added Linux Mint support to the build system. #5674
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created symlinks for `linuxmint` and `ubuntu` in `linux.d`, and removed the Ubuntu check in `BuildLinux.sh`. This is an easy way to handle derivative distributions. One particular caveat: symlinks don't play well with older versions of git on Windows. It's unlikely to be a problem unless somebody tries to commit changes to `linux.d` from windows. See: https://stackoverflow.com/questions/5917249/git-symbolic-links-in-windows An alternative approach is to use the `ID_LIKE` tag in `/etc/os-release`. See example 3 in the `os-release` manual.
|
In fact, we primarily work on Windows and often need to modify files in the Linux.d directory on Windows. |
|
Fair. I'm going to send another PR for alternative approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created symlinks for
linuxmintandubuntuinlinux.d, and removed the Ubuntu check inBuildLinux.sh. This is an easy way to handle derivative distributions.One particular caveat: symlinks don't play well
with older versions of git on Windows. It's unlikely to be a problem unless somebody tries to commit changes to
linux.dfrom windows. See: https://stackoverflow.com/questions/5917249/git-symbolic-links-in-windowsAn alternative approach is to use the
ID_LIKEtag in/etc/os-release. See example 3 in theos-releasemanual.