Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing build dependency (bc) in Dockerfile #4583

Closed
wants to merge 2 commits into from

Conversation

penguineer
Copy link
Contributor

The build was canceled due to missing bc. This PR adds the bc package to the build environment.

> [ 9/12] RUN ./BuildLinux.sh -d:
0.383 FOUND_GTK3=ii  libgtk-3-0:amd64    3.24.33-1ubuntu2.2 amd64        GTK graphical user interface library
0.383 ii  libgtk-3-bin        3.24.33-1ubuntu2.2 amd64        programs for the GTK graphical user interface library
0.383 ii  libgtk-3-common     3.24.33-1ubuntu2.2 all          common files for the GTK graphical user interface library
0.383 ii  libgtk-3-dev:amd64  3.24.33-1ubuntu2.2 amd64        development files for the GTK library
0.383 un  libgtk-3-doc        <none>             <none>       (no description available)
0.383 Changing date in version...
0.385 done
0.393 ./BuildLinux.sh: line 122: bc: command not found
------

3 warnings found (use --debug to expand):
- LegacyKeyValueFormat: "LABEL key=value" should be used instead of legacy "LABEL key value" format (line 2)
- WorkdirRelativePath: Relative workdir "BambuStudio" can have unexpected results if the base image changes (line 63)
- LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 76)
Dockerfile:70
--------------------
68 |
69 |     # Build dependencies in ./deps
70 | >>> RUN ./BuildLinux.sh -d
71 |
72 |     # Build slic3r
--------------------
ERROR: failed to solve: process "/bin/sh -c ./BuildLinux.sh -d" did not complete successfully: exit code: 127

The build is successful when bc is available.

The build was canceled due to missing bc. This commit adds the bc package
to the build environment.
@lanewei120 lanewei120 requested a review from MackBambu August 8, 2024 07:50
@MackBambu
Copy link
Contributor

MackBambu commented Aug 8, 2024

./BuildLinux.sh: line 122: bc: command not found
Error: error building at STEP "RUN ./BuildLinux.sh -d ${BUILD_LINUX_EXTRA_ARGS}": error while running runtime: exit status 127
Error: Process completed with exit code 125.

Still have the bc command loss problem.
I've made a lot of changes to BuildLinux.sh recently, and the dockerfile needs to follow suit with some adjustments.

@penguineer
Copy link
Contributor Author

This is interesting, as it worked flawless for me. I will, of course, have a look! Thank you for testing!

@penguineer
Copy link
Contributor Author

./BuildLinux.sh: line 122: bc: command not found
Error: error building at STEP "RUN ./BuildLinux.sh -d ${BUILD_LINUX_EXTRA_ARGS}": error while running runtime: exit status 127
Error: Process completed with exit code 125.

Still have the bc command loss problem. I've made a lot of changes to BuildLinux.sh recently, and the dockerfile needs to follow suit with some adjustments.

Unfortunately, I cannot reproduce that. I am running from a fresh environment and Docker Build with the script DockerBuild.sh runs fine from my branch, but throws the error on master.

@penguineer
Copy link
Contributor Author

I just realized: The action calles BuildLinux.sh directly and apparently this still fails. It might be because bc is not available on the Ubuntu Runner either.

@penguineer penguineer marked this pull request as draft August 20, 2024 08:10
@MackBambu
Copy link
Contributor

I just realized: The action calles BuildLinux.sh directly and apparently this still fails. It might be because bc is not available on the Ubuntu Runner either.

It works fine on Ubuntu runner and I don't understand why the command is lost in a docker environment, even if I reinstall it. I'm already planning to submit a version that removes the bc command.
https://github.com/MackBambu/BambuStudio/blob/cb28fa6ff99ea15186b403563a50bf8af2603188/BuildLinux.sh#L122

@penguineer
Copy link
Contributor Author

I'm already planning to submit a version that removes the bc command. https://github.com/MackBambu/BambuStudio/blob/cb28fa6ff99ea15186b403563a50bf8af2603188/BuildLinux.sh#L122

@MackBambu In this case, does it make sense to put further work into this PR?

@MackBambu
Copy link
Contributor

@MackBambu In this case, does it make sense to put further work into this PR?

no need

1 similar comment
@MackBambu
Copy link
Contributor

@MackBambu In this case, does it make sense to put further work into this PR?

no need

@MackBambu MackBambu closed this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants