Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uk lang сompatibility with version 1.8 #2913

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

iZonex
Copy link
Contributor

@iZonex iZonex commented Nov 17, 2023

Introducing Ukrainian Language Support for Version 1.8

Screenshot 2023-11-17 at 17 37 59 Screenshot 2023-11-17 at 17 12 26

Changes Description:

  • Implemented complete interface localization in Ukrainian.
  • Ensured compatibility with the new version 1.8, including interface updates and enhanced functionalities.
  • Modified resources/web/data/text.js for textual changes in the interface.
  • Updated and added localization files BambuStudio_uk.po and .mo to support the Ukrainian language.

Purpose of Changes:

The purpose of these changes is to extend the application's accessibility to Ukrainian-speaking users and update compatibility with the latest software version, thereby improving overall performance and user experience.

Copy link

@kiddden kiddden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the localization seems to be clear and correct

Copy link

@man55 man55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

грац

bbl/i18n/uk/BambuStudio_uk.po Show resolved Hide resolved
bbl/i18n/uk/BambuStudio_uk.po Outdated Show resolved Hide resolved
bbl/i18n/uk/BambuStudio_uk.po Outdated Show resolved Hide resolved
bbl/i18n/uk/BambuStudio_uk.po Outdated Show resolved Hide resolved
bbl/i18n/uk/BambuStudio_uk.po Outdated Show resolved Hide resolved
bbl/i18n/uk/BambuStudio_uk.po Show resolved Hide resolved
bbl/i18n/uk/BambuStudio_uk.po Outdated Show resolved Hide resolved
bbl/i18n/uk/BambuStudio_uk.po Show resolved Hide resolved
bbl/i18n/uk/BambuStudio_uk.po Show resolved Hide resolved
bbl/i18n/uk/BambuStudio_uk.po Show resolved Hide resolved
@iZonex iZonex closed this Nov 21, 2023
@iZonex iZonex deleted the uk-lang-1.8 branch November 21, 2023 21:40
@iZonex iZonex restored the uk-lang-1.8 branch November 21, 2023 22:54
@iZonex iZonex reopened this Nov 21, 2023
@iZonex iZonex requested a review from man55 November 21, 2023 22:59
@iZonex
Copy link
Contributor Author

iZonex commented Nov 21, 2023

@lanewei120 Can you please review and merge before release 1.8. We with our Ukraine community did to much improvements for better translation.

@lanewei120
Copy link
Collaborator

@iZonex

thanks for doing this
I have just synced the codes of master to newest
could you rebase to the master, and submit it again

we will merge as soon as you finish

@lanewei120
Copy link
Collaborator

@iZonex
is it ready now?

@iZonex
Copy link
Contributor Author

iZonex commented Nov 22, 2023

@iZonex is it ready now?

@lanewei120 Yes!

Please take a look on translations around code base with "Delete Presets" is duplicated is ok, but I think Delete Presets and Delete presets is can be duplicate by typo

msgid "Delete Preset"
msgstr ""

msgid "Are you sure to delete the selected preset?"
msgstr ""

msgid "Delete preset"
msgstr ""

@lanewei120
Copy link
Collaborator

@iZonex is it ready now?

@lanewei120 Yes!

Please take a look on translations around code base with "Delete Presets" is duplicated is ok, but I think Delete Presets and Delete presets is can be duplicate by typo

msgid "Delete Preset" msgstr ""

msgid "Are you sure to delete the selected preset?" msgstr ""

msgid "Delete preset" msgstr ""

that is ok currently
thanks for doing this

@lanewei120 lanewei120 closed this Nov 22, 2023
@lanewei120 lanewei120 reopened this Nov 22, 2023
@lanewei120
Copy link
Collaborator

image

@lanewei120
Copy link
Collaborator

seems can not rebase
please rebase it manually and submit again

@iZonex

@iZonex
Copy link
Contributor Author

iZonex commented Nov 22, 2023

seems can not rebase please rebase it manually and submit again

@iZonex

@lanewei120 rebased to one commit for head.

commit 028c236 (HEAD -> uk-lang-1.8, origin/uk-lang-1.8)
- add: Ukrainian lang support for 1.8

commit 7aa443d (origin/master, origin/HEAD, master)
- FIX: some translation problems

@lanewei120 lanewei120 merged commit c5a7998 into bambulab:master Nov 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants