-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BambuLab machine profile cleanup sync #2868
base: master
Are you sure you want to change the base?
Conversation
I finally finished the refactor of the BBL machine profile. It was an intricate task that demanded careful consideration of each setting. Please review and share any thoughts or suggestions! Changes Made:
Future Steps:
|
@adripo Awesome work!Thanks for your hard work and contribution. I notice that you modify the "common" profiles ,and this will affect almost all presets in BBL due to the inheritance mechanism .I have written a python script and later i will check the differences between before and after modification . And for the options order , we already have an internal sorting rule and may conflict with your rules . |
@adripo For the adjustment of the preset hierarchy structure , we will make comprehensive adjustments in next version , and your commit will be taken into consideration . Do you mind if i donnot merge the PR instantly and acknowledege your contributions in later commit ? |
@XunZhangBambu That is correct, I removed all the unnecessary and always overwritten configurations. Now the common is "clean" and only contains the options that are shared between almost all the profiles. I created the Machine common to put all the options that are shared by all the nozzles of the same machine and tried to keep the nozzle profiles as similar as possible for easier maintenance. The options order is not important, you can change it following the rules of the script. |
Sure, not an issue on my side, just please keep them simpler, similar to my solution. I also found some human errors introduced because of poor maintainability of the current structure. This can be easily avoid when the nozzle files are more similar between them. For example here the 0.8 profile references a 0.6 machine: Also file naming doesn't follow any common rule
Those are only some of the issues I identified and tried to solve with my PR. Feel free to adapt it for a better solution or use it as a reference, but it would be a big advantage to have a simple and maintainable structure without duplicated options. |
Continue from #2112 that created some confusion after rebase.
I am cherry picking the original commits and updating with latest modifications.