Skip to content

feat(GitOpsConfig): release apiVersion 2 - #167

Merged
christiansiegel merged 1 commit into
masterfrom
feat/gitopsconfig-v2
Aug 5, 2021
Merged

christiansiegel merged 1 commit into
masterfrom
feat/gitopsconfig-v2

Conversation

@christiansiegel

Copy link
Copy Markdown
Member

No description provided.

@joachimprinzbach

joachimprinzbach commented Aug 5, 2021 •

Copy link
Copy Markdown
Member

I did some tests:
baloise-incubator/gitops-nginx-demo#56
baloise-incubator/gitops-nginx-demo#55
baloise-incubator/gitops-nginx-demo#54

The one with the short preview hash is not reachable (ns and route seem to be fine, is healthy synce), i am still looking into it. Rest (no api version, beta api version) seems to work fine.

// Edit: My bad, forgot that the gitopsconfig is always retrieved from master ^^ Need to recreate the PR's

@joachimprinzbach

Copy link
Copy Markdown
Member

Works like a charm - awesome work @christiansiegel!

I would add the generator and also the changes between the versions somewhere in the docs and maybe also in the release notes?

What about the following release procedure?

  • release this change as 5.0.0 with API version 2 -> is a compatibility release that makes migrating to v2 easier
  • release 6.0.0 with API version 1 and unversioned config support removed as a breaking change

No breaking changes - just a major release with `.gitops.config.yaml` API version v2. Convert your current GitOps config with https://christiansiegel.github.io/gitopscli-config-converter/
@christiansiegel

Copy link
Copy Markdown
Member Author

I amended the previous commit with

  • updated commit message (major release + mentioned converter)
  • added info box to doc

@joachimprinzbach

Copy link
Copy Markdown
Member

Great, thx a lot - ready to release :-)

@christiansiegel
christiansiegel merged commit a2cbe03 into master Aug 5, 2021
@christiansiegel
christiansiegel deleted the feat/gitopsconfig-v2 branch August 5, 2021 18:41
@christiansiegel

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants