Bal 4393 document above 10mb failed to upload with no indicative #3446

chesterkmr · 2025-06-24T12:47:40Z

No description provided.

changeset-bot · 2025-06-24T12:47:44Z

⚠️ No Changeset found

Latest commit: 44491c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-06-24T12:47:46Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Omri-Levy · 2025-07-02T08:38:41Z

...ui/src/components/organisms/Form/DynamicForm/providers/ValidatorWrapper/ValidatorWrapper.tsx

+        entityType: document.businessId ? 'business' : 'ubo',
+        entityId: document.businessId ? document.businessId : document.endUserId!,


Please don't use ternary for similar checks, just because there's no business it does not indicate it's an end-user.

This logic is taken from document-validator as reference for now. Currently i dont have any better approach. Reworking this means reworking other validator and its something that out of scope in current context.

Omri-Levy · 2025-07-02T08:39:12Z

...ui/src/components/organisms/Form/DynamicForm/providers/ValidatorWrapper/ValidatorWrapper.tsx

+
+      return {
+        ...acc,
+        [fileId]: new File([], document.files?.[0]?.name!, {


In general we should throw more errors or runtime validate over using null assertions.

Omri-Levy · 2025-07-02T08:40:37Z

...rc/components/organisms/Form/DynamicForm/validators/document-size/document-size-validator.ts

+  if (fileSizeLimit && file.size > fileSizeLimit) {
+    return true;
+  }
+
+  return false;


Suggested change

if (fileSizeLimit && file.size > fileSizeLimit) {

return true;

}

return false;

return fileSizeLimit && file.size > fileSizeLimit;

Omri-Levy · 2025-07-02T08:41:34Z

...rc/components/organisms/Form/DynamicForm/validators/document-size/document-size-validator.ts

+  IDocumentSizeValidatorParams,
+  TBaseValidators | 'documentSize',
+  IValidatorWrapperContext
+> = (value, params, schema, context) => {


Consider using params over positional arguments.

Omri-Levy · 2025-07-02T08:42:16Z

...rc/components/organisms/Form/DynamicForm/validators/document-size/document-size-validator.ts

+      entityId: value.ballerineEntityId || value.__id!,
+    });
+
+    file = context?._files[documentId];


Didn't we remove properties like __id and __files?

Its something that added during runtime and used only for validation. Never gets to actual context.

Omri-Levy · 2025-07-02T08:43:54Z

...organisms/Form/DynamicForm/fields/DocumentField/hooks/useDocumentUpload/useDocumentUpload.ts

      setFile(file);

+      if (document) {
+        void deleteDocumentFiles(document.id);


Does this use react-query? How come it does not use the sync mutate?

It uses react-query mutation under the hood yes, but in current case its more like side effect and doesnt need to be "sync" awaited

chesterkmr added 2 commits June 24, 2025 15:40

feat: implemented documentsSize validator

795a2f7

feat: moved file size limit to common & updated imports

44491c8

Omri-Levy reviewed Jul 2, 2025

View reviewed changes

Omri-Levy approved these changes Jul 2, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bal 4393 document above 10mb failed to upload with no indicative #3446

Bal 4393 document above 10mb failed to upload with no indicative #3446

Uh oh!

chesterkmr commented Jun 24, 2025

Uh oh!

changeset-bot bot commented Jun 24, 2025

Uh oh!

coderabbitai bot commented Jun 24, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Omri-Levy Jul 2, 2025

Uh oh!

chesterkmr Jul 2, 2025

Uh oh!

Omri-Levy Jul 2, 2025

Uh oh!

Omri-Levy Jul 2, 2025

Uh oh!

Omri-Levy Jul 2, 2025

Uh oh!

Omri-Levy Jul 2, 2025

Uh oh!

chesterkmr Jul 2, 2025

Uh oh!

Omri-Levy Jul 2, 2025

Uh oh!

chesterkmr Jul 2, 2025

Uh oh!

Uh oh!

		entityType: document.businessId ? 'business' : 'ubo',
		entityId: document.businessId ? document.businessId : document.endUserId!,

Bal 4393 document above 10mb failed to upload with no indicative #3446

Are you sure you want to change the base?

Bal 4393 document above 10mb failed to upload with no indicative #3446

Uh oh!

Conversation

chesterkmr commented Jun 24, 2025

Uh oh!

changeset-bot bot commented Jun 24, 2025

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Jun 24, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CodeRabbit Configuration File (`.coderabbit.yaml`)