chore: fix test

[liorzam]

Summary by CodeRabbit

• Tests
  • Introduced a new test case in the Rule Engine to verify if the establishment date is within the last year, enhancing testing coverage.
  • Simplified test setup by replacing a complex object with a streamlined context object for better maintainability.
  • Improved readability of the test code with formatting adjustments.

[changeset-bot]

⚠️ No Changeset found

Latest commit: dd79885

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The changes introduce a new test case in the Rule Engine test suite, focused on validating whether the establishDate falls within the last year. This enhances test coverage by ensuring accurate date evaluations aligned with business rules. Additionally, the context setup has been simplified by replacing a complex object with a generic context, streamlining the testing process and enhancing the maintainability of the test cases.

Changes

Files	Change Summary
services/workflows-service/src/rule-engine/core/test/rule-engine.unit.test.ts	Added a test case for validating establishDate within the last year; simplified context setup.

Poem

In the meadow where bunnies play,
A test was added to brighten the day.
With dates that dance, oh so near,
The rules are clear, let’s all cheer!
A hop, a skip, our code’s in tune,
With simpler tests, we'll reach the moon! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f8d4585 and dd79885.

Files selected for processing (1)

• services/workflows-service/src/rule-engine/core/test/rule-engine.unit.test.ts (2 hunks)

Additional comments not posted (1)

services/workflows-service/src/rule-engine/core/test/rule-engine.unit.test.ts (1)

Line range hint 296-361:
LGTM! Well-structured test case with comprehensive scenarios.

The new test case covers multiple scenarios, including edge cases, ensuring robust validation of the establishDate logic.

However, consider verifying the performance impact of using JSON.parse(JSON.stringify(context)) for context setup, especially in larger test suites.