Migrate to Java 21 #917
Open
Migrate to Java 21 #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravinperera00
force-pushed
the
java21
branch
3 times, most recently
from
a3ebdd4 to
c08bfca
Compare
native/src/main/java/io/ballerina/stdlib/nats/basic/consumer/DefaultMessageHandler.java
Outdated
Show resolved
Hide resolved
ravinperera00
force-pushed
the
java21
branch
3 times, most recently
from
b25c6ee to
b6ae5d7
Compare
ravinperera00
requested review from
niveathika,
aashikam and
shafreenAnfar
as code owners
HindujaB
reviewed
Dec 6, 2024
native/src/main/java/io/ballerina/stdlib/nats/basic/consumer/DefaultMessageHandler.java
Outdated
Show resolved
Hide resolved
| natsMetricsReporter.reportProducerError(subject, NatsObservabilityConstants.ERROR_TYPE_REQUEST); | ||
| return bError; | ||
| } | ||
| BMap<BString, Object> populatedRecord = ValueCreator.createRecordValue(msgRecord, |
There was a problem hiding this comment.
This should not be inside yieldAndRun since it will call ballerina runtime
There was a problem hiding this comment.
Changed in b692a44. Will this work?
ravinperera00
force-pushed
the
java21
branch
from
c5b6925 to
5239c9b
Compare
ravinperera00
force-pushed
the
java21
branch
from
5239c9b to
b692a44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes:
Examples
Checklist