Remove some limitation from the output of toRecord() #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #418 +/- ##
============================================
- Coverage 90.58% 90.35% -0.23%
Complexity 82 82
============================================
Files 7 7
Lines 361 363 +2
Branches 134 133 -1
============================================
+ Hits 327 328 +1
- Misses 21 22 +1
Partials 13 13
Continue to review full report at Codecov.
|
daneshk
reviewed
Apr 12, 2022
ballerina/xmldata.bal
Outdated
| JsonOptions newOptions = { | ||
| arrayEntryTag: options.arrayEntryTag == "" ? "item" : options.arrayEntryTag, | ||
| attributePrefix: options.attributePrefix == "" ? "@" : options.attributePrefix | ||
| }; |
There was a problem hiding this comment.
Do we need this? why can't we just use input options
There was a problem hiding this comment.
Removed.
daneshk
approved these changes
Apr 15, 2022
|
@kalaiyarasiganeshalingam please update the changelog |
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The following limitation remove from the output of toRecord()
_instead of:. Now, this pr has removed that and allowed users to use ":".\#content.Related to ballerina-platform/ballerina-library#2810
Examples
Checklist