-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing viewport details in lang spec pages #1317
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presentational stuff like this should go in spec.xsl not spec.html.
I have updated the spec.xsl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a tiny nit, but please move the added line one line down, so it's next to the other meta tag.
Sorry my bad. Committed the wrong file. Could you please review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't make myself clear in the previous comment. I just want the new <meta>
tag, which you added before the <title>
tag to be moved so that it is after the <title>
tag, and next to the the <meta charset
tag.
I have fixed the meta tag order. Could you please review again. |
@jclark, Could you please review this PR? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems way too complicated. I would just add something like this to add the additional meta tag after the existing meta tag.
<xsl:template match="meta[@charset]">
<xsl:copy-of select="."/>
<meta name="viewport" content="width=device-width, initial-scale=1"/>
</xsl:template>
Purpose
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning