Add persists code samples for ballerina bff #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerajayasoma
requested changes
Nov 7, 2023
persists/backend_server/server.bal
Outdated
| }; | ||
|
|
||
| // Example: http://localhost:9090/sales/orders | ||
| isolated resource function post orders(Order orderEntry) returns http:Ok|http:InternalServerError|http:BadRequest|error { |
There was a problem hiding this comment.
Why are we sending both http:InternalServerError and error here? My suggestion is to stick with one here and use that pattern for all resource functions.
There was a problem hiding this comment.
updated, Please check.
I think http:InternalServerError is the best option.
But, In the L14 and L34, those resource functions returns error to keep the simplicity.
Other resource functions returns http:InternalServerError.
sm1990
reviewed
Nov 10, 2023
persistently-store-data-using-Ballerina/frontend_server/src/layouts/dashboard/side-nav-item.js
Outdated
Show resolved
Hide resolved
sm1990
reviewed
Nov 10, 2023
persistently-store-data-using-Ballerina/frontend_server/src/layouts/dashboard/side-nav.js
Outdated
Show resolved
Hide resolved
chathurace
reviewed
Nov 13, 2023
persistently-store-data-using-Ballerina/backend_server/server.bal
Outdated
Show resolved
Hide resolved
MaryamZi
reviewed
Nov 14, 2023
persistently-store-data-using-Ballerina/backend_server/server.bal
Outdated
Show resolved
Hide resolved
persistently-store-data-using-Ballerina/backend_server/server.bal
Outdated
Show resolved
Hide resolved
persistently-store-data-using-Ballerina/backend_server/server.bal
Outdated
Show resolved
Hide resolved
sm1990
previously approved these changes
Nov 14, 2023
anupama-pathirage
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add code samples related to
ballerina-persistsmodule for ballerina backend to frontend(bff).