Skip to content

changed to use OS provided versions of cpanminus #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
.cbfProject

#build files
docker-compose.yml
docker-compose.*
bin/*
vols*/*
cbf/CRF.properties
CBF.properties
scanned.paths
*.loaded
**/CRF.properties
**/CBF.properties
**/scanned.paths
**/*.loaded

# Information files
LICENSE
Expand Down
8 changes: 8 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,2 +1,10 @@
*.bmp filter=lfs diff=lfs merge=lfs -text
*.gz filter=lfs diff=lfs merge=lfs -text
*.hpi filter=lfs diff=lfs merge=lfs -text
*.jar filter=lfs diff=lfs merge=lfs -text
*.jpi filter=lfs diff=lfs merge=lfs -text
*.png filter=lfs diff=lfs merge=lfs -text
*.tar filter=lfs diff=lfs merge=lfs -text
*.tgz filter=lfs diff=lfs merge=lfs -text
*.zip filter=lfs diff=lfs merge=lfs -text

4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ logs
vols/*
vols-rw/*
build/container_build_framework*
cbf/CRF.properties
CBF.properties
**/CRF.properties
**/CBF.properties
scanned.paths
*.loaded
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ ENV DEBUG_TRACE=0


# cpanimus version being bundled in this docker image
ARG CPANIMUS_VERSION=1.7044
LABEL cpanimus.version=$CPANIMUS_VERSION
ARG CPANMINUS_VERSION=1.7044
LABEL cpanminus.version=$CPANMINUS_VERSION


# build content
Expand Down
1 change: 1 addition & 0 deletions build/action_folders/02.packages/04.carton.alpine
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@

declare -a PKGS=( libxml2
libxml2-dev
perl-app-cpanminus
python )
12 changes: 12 additions & 0 deletions build/action_folders/02.packages/04.carton.fedora
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# carton Packages

declare -a PKGS=( libxml2
libxml2-devel
python
libssh2
libuuid-devel
# rh-perl526-perl-App-cpanminus
rh-perl526-perl-Env
uuid
uuid-devel
)
11 changes: 11 additions & 0 deletions build/action_folders/02.packages/04.carton.ubuntu
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# carton Packages

declare -a PKGS=( libxml2
libxml2-devel
python
cpanimus
libssh2
libuuid-devel
uuid
uuid-devel
)
8 changes: 0 additions & 8 deletions build/action_folders/04.downloads/01.CPANIMUS

This file was deleted.

3 changes: 0 additions & 3 deletions build/action_folders/05.applications/01.cpanimus

This file was deleted.

2 changes: 1 addition & 1 deletion build/action_folders/05.applications/02.carton
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
#!/bin/bash

( cpan install Carton )
PERL_MM_USE_DEFAULT=1 cpan install Carton ||:
16 changes: 5 additions & 11 deletions build/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,9 @@ case "$(osname)" in
apk update
apk add --no-cache bash ca-certificates openssl
fi;;
centos)
centos|fedora)
# ensure we have wget support
if [ -z "$(which wget)" ]; then
yum update
yum install -y wget ca-certificates openssl
fi;;
fedora)
# ensure we have wget support
if [ -z "$(which wget)" ]; then
if [ ! -e /usr/bin/wget ]; then
yum update
yum install -y wget ca-certificates openssl
fi;;
Expand All @@ -62,10 +56,10 @@ elif [ "$CBF_VERSION" ]; then
CBF_URL="https://github.com/ballab1/container_build_framework/archive/${CBF_VERSION}.tar.gz"
echo "Downloading CBF:$CBF_VERSION from $CBF_URL"

if [ $(which wget) ]; then
if [ -e /usr/bin/wget ]; then
wget --no-check-certificate --quiet --output-document="$CBF_TGZ" "$CBF_URL" || die "Failed to download $CBF_URL"

elif [ $(which curl) ]; then
elif [ -e /usr/bin/curl ]; then
curl --insecure --silent --output "$CBF_TGZ" "$CBF_URL" || die "Failed to download $CBF_URL"

else
Expand All @@ -92,4 +86,4 @@ fi

echo "loading framework from ${cbf_dir}"
chmod 755 "${cbf_dir}/cbf/bin/build.sh"
exec "${cbf_dir}/cbf/bin/build.sh" "$@"
exec "${cbf_dir}/cbf/bin/build.sh" "$@"
4 changes: 2 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ services:
args:
CBF_VERSION: ${CBF_VERSION:-}
CONTAINER_NAME: perl-carton
CPANIMUS_VERSION: ${CPANIMUS_VERSION:-1.7044}
CPANMINUS_VERSION: ${CPANMINUS_VERSION:-1.7044}
FROM_BASE: ${DOCKER_REGISTRY:-}${CONTAINER_OS:-}perl/${PERL_VERSION:-5.26.2}:${BASE_TAG:-latest}
cache_from:
- ${DOCKER_REGISTRY:-}${CONTAINER_OS:-}alpine:3.8
Expand All @@ -26,4 +26,4 @@ services:
container_name: carton
environment:
DEBUG_TRACE: ${DEBUG_TRACE:-0}
image: ${DOCKER_REGISTRY:-}${CONTAINER_OS:-}perl-carton/${CPANIMUS_VERSION:-1.7044}:${CONTAINER_TAG:-latest}
image: ${DOCKER_REGISTRY:-}${CONTAINER_OS:-}perl-carton/${CPANMINUS_VERSION:-1.7044}:${CONTAINER_TAG:-latest}