Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analytics: Fix broken mixpanel reporting #960

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Conversation

dimitrisnl
Copy link
Contributor

Connects-to: #931
Change-type: patch
Signed-off-by: Dimitrios Lytras dimitrios@balena.io

@dimitrisnl
Copy link
Contributor Author

DOMContentLoaded would fire way before the async request resolved.

Connects-to: #931
Change-type: patch
Signed-off-by: Dimitrios Lytras <dimitrios@balena.io>
@dimitrisnl
Copy link
Contributor Author

@resin-ci retest

@dimitrisnl dimitrisnl merged commit e1d5ca2 into master Nov 16, 2018
@ghost ghost removed the in progress label Nov 16, 2018
@dimitrisnl dimitrisnl deleted the 931-fix-mixpanel branch November 16, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants