fix EGL error and possible incorrect sample count in eglSwapBuffers_renderdoc_hooked
#3624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-morales
force-pushed
the
3623-fix-swapbuffers-sample-update
branch
from
49acfe2 to
1056485
Compare
|
For future reference there is no reason to make an issue and then immediately making a pull request fixing that issue - you can just open the pull request and include any information here as it then generates less noise on the repository for anyone watching. This change looks fine to me but I'd like to get @cmannett85-arm to double check it as EGL is primarily/mostly for android so making sure that this doesn't look like it'd cause issues there. |
baldurk
approved these changes
Jun 9, 2025
|
We haven't had any reports on this before, but the change certainly looks correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3623
This patch makes sure
data.egl_cfgis set before callingeglSwapBuffers_renderdoc_hooked, making sure thatEGL.GetConfigAttribdoes not produce an error. Incidentally, as this likely didn't work before, this will probably get the correct sample count of the config viaEGL.GetConfigAttrib.